Remove kwargs in learn and update #949
Labels
breaking changes
Changes in public interfaces. Includes small changes or changes in keys
major
Large changes that cannot or should not be broken down into smaller ones
refactoring
No change to functionality
Milestone
That's a tricky one since
learn
implementation are currently not cleanly separated (violate Liskov substitution) and rely on kwargs in order to remain functional. E.g. some implementations of learn take therepeat
kwarg (the on-policy ones), and some don't.Generally, the control flow between
trainer.update_policy
andpolicy.learn
may need to be redesigned or at least improvedThe text was updated successfully, but these errors were encountered: