Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TH08: MIDI BGM ignores the BGM volume setting #24

Open
nmlgc opened this issue Sep 26, 2018 · 2 comments
Open

TH08: MIDI BGM ignores the BGM volume setting #24

nmlgc opened this issue Sep 26, 2018 · 2 comments
Labels

Comments

@nmlgc
Copy link
Contributor

nmlgc commented Sep 26, 2018

I expected that the setting would apply to both BGM modes.

@nmlgc nmlgc added the ZUN bug label Sep 26, 2018
@32th-System
Copy link
Member

The function to set MIDI volume with the MIDI API the game uses seems to be midiOutSetVolume, however, when trying to call it, it simply returns MMSYSERR_NOTSUPPORTED, and the MIDI volume stays the same.

@nmlgc
Copy link
Contributor Author

nmlgc commented Jun 28, 2024

Touhou's MIDI code originates from Shuusou Gyoku, which had the same issue. The best solution there was intercepting every CC #7 message and factoring the BGM volume setting into its parameter; using the semantically correct Universal Realtime Master Volume message would actually be more of a hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants