Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy wiki-side generation after moving to Github #6

Open
brliron opened this issue Mar 30, 2023 · 2 comments
Open

Remove legacy wiki-side generation after moving to Github #6

brliron opened this issue Mar 30, 2023 · 2 comments

Comments

@brliron
Copy link
Member

brliron commented Mar 30, 2023

We moved base_tsa from MediaWiki to Github 9 years ago, yet we still have way too much stuff that this move made obsolete. Things like https://browse.thpatch.net/lang_ja/th185.js , https://browse.thpatch.net/lang_ja/th14.v1.00b.js , or the entirety of https://browse.thpatch.net/base_tsa/ don't have any reason to exist anymore. Most of them are also terribly outdated, which means they're quite likely to break things if they're used.

We should work on removing them. For each file (or section of a file), it can be done in 3 steps:

  • Replace the MediaWiki page (or part of the MediaWiki page) generating them with the "moved to Github" template.
  • Remove the file on the server, and set it to null in files.js.
  • Remove the generation code in this repo if it isn't needed anymore.

Sometimes, you won't have to do all 3 steps. For example, lang_ja/th185.js doesn't have the "replace the MediaWiki page" step because we still want our nice-looking header on the wiki, we just want it to not generate any patch file. Or lang_ja/th14.v1.00b.js doesn't have the "remove the generation code" step because that code is also used by the skipgame patch, which is still hosted on MediaWiki (we could move it to Github, but that's another question).

@DankRank
Copy link
Member

Rather than removing the pages outright, just empty them and keep the "moved to github" template. This keeps the revision history publicly available.

@brliron
Copy link
Member Author

brliron commented Apr 3, 2023

We have such a template? I didn't know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants