Store the source language of TL-included pages.

Originally, this was meant to establish consistency with a new
`tpc_games` table, which would have included a language code in order
to automatically set the correct source language for non-TL-included
pages (like the omake.txt and HTML Manual ones). After thinking about
that idea for a while, I wasn't convinced that it justified the added
complexity, but this commit still seems like a good one: Adding a code
to `tpc_tl_source_pages` allows us to ditch getNamespaceBaseLanguage(),
and supports the hypothetical use case of non-Japanese game translation
with this extension.

Author: nmlgc

TPCPatchMap.php

@@ -26,14 +26,15 @@ protected static function mergePatch( &$map, &$patch ) {
 	// -------------------------
 
 	/**
-	  * @return bool `true` if the given page is part of `tpc_tl_source_pages`.
+	  * @return ?string Source language of the given page, if it is part of `tpc_tl_source_pages`.
 	  */
-	public static function isTLIncludedPage( int $namespace, string $title ): bool {
+	public static function getTLPageSourceLanguage( int $namespace, string $title ): ?string {
 		$dbr = MediaWikiServices::getInstance()->getDBLoadBalancer()->getConnection( DB_REPLICA );
-		return $dbr->selectRow( 'tpc_tl_source_pages', 1, array(
+		$row = $dbr->selectRow( 'tpc_tl_source_pages', 'tlsp_code', array(
 			'tlsp_namespace' => $namespace,
 			'tlsp_title' => $title
-		)) !== false;
+		));
+		return ( $row->tlsp_code ?? null );
 	}
 
 	/**
@@ -115,17 +116,17 @@ public static function get( $title ) {
 		$root = $title->getRootText(); // Might indicate a game
 
 		// Source page?
-		if ( self::isTLIncludedPage( $namespace, $title->getText() ) ) {
+		if ( $code = self::getTLPageSourceLanguage( $namespace, $title->getText() ) ) {
 			$game = $title->isSubpage() ? lcfirst( $root ) : "";
-			return self::buildTLMapping( $game, TPCUtil::getNamespaceBaseLanguage( $namespace ) );
+			return self::buildTLMapping( $game, $code );
 		}
 
 		// If $title is a translated page, getBaseText() gives us the source page…
 		$base = $title->getBaseText();
 
 		// … which we can check against the same database table to check if this is a translated
 		// page of a registered source page.
-		if ( self::isTLIncludedPage( $namespace, $base ) ) {
+		if ( self::getTLPageSourceLanguage( $namespace, $base ) ) {
 			$game = ( $root != $base ) ? lcfirst( $root ) : "";
 			return self::buildTLMapping( $game, $title->getSubpageText() );
 		}

TPCUtil.php

@@ -8,16 +8,6 @@
   */
 
 class TPCUtil {
-	/**
-	  * Returns the language of original content in the given namespace.
-	  *
-	  * @param int $namespace Namespace number
-	  * @return string Language code
-	  */
-	public static function getNamespaceBaseLanguage( $namespace ) {
-		return $namespace == 0 ? 'ja' : $wgLanguageCode;
-	}
-
 	/**
 	  * Normalizes a hook name.
 	  *

TouhouPatchCenter.body.php

@@ -226,8 +226,8 @@ public static function onMultiContentSave(
 
 	public static function onPageContentLanguage( Title $title, &$pageLang, $userLang ) {
 		$namespace = $title->getNamespace();
-		if ( TPCPatchMap::isTLIncludedPage( $namespace, $title->getText() ) ) {
-			$pageLang = Language::factory( TPCUtil::getNamespaceBaseLanguage( $namespace ) );
+		if ( $code = TPCPatchMap::getTLPageSourceLanguage( $namespace, $title->getText() ) ) {
+			$pageLang = Language::factory( $code );
 		}
 	}
 

hooks/TPCInclude.php

@@ -76,6 +76,10 @@ public static function onTLInclude( &$tpcState, &$title, &$temp ) {
 		$insert = array(
 			'tlsp_namespace' => $targetTitle->getNamespace(),
 			'tlsp_title' => $targetTitle->getText(),
+
+			// This makes hypothetical support for non-Japanese games as easy as reading this value
+			// from $temp->params[2] instead.
+			'tlsp_code' => 'ja',
 		);
 		$dbw->insert( 'tpc_tl_source_pages', $insert, __METHOD__, 'IGNORE' );
 		return true;

tpc_tl_source_pages.sql

@@ -7,5 +7,8 @@ CREATE TABLE /*_*/tpc_tl_source_pages (
 	-- Page title
 	tlsp_title varchar(255) NOT NULL,
 
+	-- Source language code
+	tlsp_code varchar(63) NOT NULL,
+
 	PRIMARY KEY (tlsp_namespace, tlsp_title)
 ) /*$wgDBTableOptions*/;