Fixed issue when scan was not happening in case of checksum mismatch

Author: aaquibzama-tw

detector/filename_detector_test.go

@@ -143,6 +143,8 @@ func shouldNotFailWithDefaultDetectorAndIgnores(fileName, ignore string, t *test
 
 	fileIgnoreConfig := FileIgnoreConfig{}
 	fileIgnoreConfig.FileName = ignore
+	fileIgnoreConfig.IgnoreDetectors = make([]string, 1)
+	fileIgnoreConfig.IgnoreDetectors[0] = "filename"
 	talismanRCIgnore := TalismanRCIgnore{}
 	talismanRCIgnore.FileIgnoreConfig = make([]FileIgnoreConfig, 1)
 	talismanRCIgnore.FileIgnoreConfig[0] = fileIgnoreConfig

detector/filesize_detector_test.go

@@ -31,6 +31,8 @@ func TestShouldNotFlagIgnoredLargeFiles(t *testing.T) {
 	filename := "filename"
 	fileIgnoreConfig := FileIgnoreConfig{}
 	fileIgnoreConfig.FileName = filename
+	fileIgnoreConfig.IgnoreDetectors = make([]string, 1)
+	fileIgnoreConfig.IgnoreDetectors[0] = "filesize"
 	talismanRCIgnore := TalismanRCIgnore{}
 	talismanRCIgnore.FileIgnoreConfig = make([]FileIgnoreConfig, 1)
 	talismanRCIgnore.FileIgnoreConfig[0] = fileIgnoreConfig

detector/ignores.go

@@ -98,7 +98,7 @@ func NewIgnore(pattern string, comment string) Ignore {
 
 func (i FileIgnoreConfig) isEffective(detectorName string) bool {
 	return !isEmptyString(i.FileName) &&
-		(contains(i.IgnoreDetectors, detectorName) || len(i.IgnoreDetectors) == 0)
+		contains(i.IgnoreDetectors, detectorName)
 }
 
 

detector/ignores_test.go

@@ -68,9 +68,9 @@ func TestShouldParseIgnoreLinesProperly(t *testing.T) {
 func TestDirectoryPatterns(t *testing.T) {
 	assertAccepts("foo/", "", "bar", t)
 	assertAccepts("foo/", "", "foo", t)
-	assertDenies("foo/", "", "foo/bar", t)
-	assertDenies("foo/", "", "foo/bar.txt", t)
-	assertDenies("foo/", "", "foo/bar/baz.txt", t)
+	assertDenies("foo/", "filename", "foo/bar", t)
+	assertDenies("foo/", "filename", "foo/bar.txt", t)
+	assertDenies("foo/", "filename", "foo/bar/baz.txt", t)
 }
 
 //Need to work on this test case as it deals with comments and talismanrc does not deal in comments
@@ -91,7 +91,7 @@ func TestIgnoringDetectors(t *testing.T) {
 }
 
 func assertDenies(line, ignoreDetector string, path string, t *testing.T) {
-	assertDeniesDetector(line, ignoreDetector, path, "someDetector", t)
+	assertDeniesDetector(line, ignoreDetector, path, "filename", t)
 }
 
 func assertDeniesDetector(line, ignoreDetector string, path string, detectorName string, t *testing.T) {