Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Substack logo #93

Closed
douglas-johnson opened this issue Jun 6, 2023 · 3 comments · Fixed by #113
Closed

Substack logo #93

douglas-johnson opened this issue Jun 6, 2023 · 3 comments · Fixed by #113
Assignees

Comments

@douglas-johnson
Copy link
Member

Can we add a Social Link variation for substack that includes their logo?

Guide to variations:
https://developer.wordpress.org/block-editor/reference-guides/block-api/block-variations/

It looks like all the current social icons are variations:
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/variations.js

Here's an svg version of their logo you can adapt to fit the SVG component used in the social links.

<svg width="24" height="24" viewBox="0 0 24 24" version="1.1">
	<path d="m22.54,5.41H1.46v2.84h21.08v-2.84Z"/>
	<path d="m1.46,10.81v13.19l10.54-5.89,10.54,5.89v-13.19H1.46Z"/>
	<path d="m22.54,0H1.46v2.84h21.08V0Z"/>
</svg>

Example SVG component icon
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/icons/facebook.js

@jessica-townsend
Copy link
Contributor

@douglas-johnson I have this started locally and I'm able to select a block variation with the correct name and logo in the editor. However, the default icon displays on the frontend. It looks like the following functions control what icon gets displayed:
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/index.php#L47
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/index.php#L94
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/index.php#L127

What do you think would be the best method for the substack logo to be shown on the frontend?

@douglas-johnson
Copy link
Member Author

What in the world? That suuuucks. They don't have a filter to add another service.

Seems like this PR to add one stalled out in the fall.

WordPress/gutenberg#30749

Hold for now

@douglas-johnson
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants