-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Substack logo #93
Comments
@douglas-johnson I have this started locally and I'm able to select a block variation with the correct name and logo in the editor. However, the default icon displays on the frontend. It looks like the following functions control what icon gets displayed: What do you think would be the best method for the substack logo to be shown on the frontend? |
What in the world? That suuuucks. They don't have a filter to add another service. Seems like this PR to add one stalled out in the fall. Hold for now |
Can we add a Social Link variation for substack that includes their logo?
Guide to variations:
https://developer.wordpress.org/block-editor/reference-guides/block-api/block-variations/
It looks like all the current social icons are variations:
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/variations.js
Here's an svg version of their logo you can adapt to fit the SVG component used in the social links.
Example SVG component icon
https://github.com/WordPress/gutenberg/blob/trunk/packages/block-library/src/social-link/icons/facebook.js
The text was updated successfully, but these errors were encountered: