Example usage snippits on landing page #293
Conversation
jasonramirez
commented
Nov 20, 2015
jasonramirez
commented
- Shrink hero to 1/2 viewport height
- Add example code steps
- Add code highlighting via highlight.js
* Shrink hero to 1/2 viewport height * Add example code steps * Add code highlighting via highlight.js
| var PageSetup = (function () { | ||
| return { | ||
| initialize: function () { | ||
| hljs.initHighlightingOnLoad(); |
| @@ -0,0 +1,24 @@ | |||
| .code { | |||
| border: solid 1px $code-border-color; | |||
There was a problem hiding this comment.
Properties should be ordered background-color, border, border-radius, font-size, margin-bottom
| } | ||
| } | ||
|
|
||
| .code__header { |
There was a problem hiding this comment.
Selector code__header should be written in lowercase with hyphens
|
@jasonramirez this LOOKs amazing! Unfortunately, the README has been recently updated, which makes a lot of this text out of date. https://github.com/thoughtbot/ember-cli-rails#usage I wonder if we could somehow style the page the way you've laid out and somehow import in some markdown. Do you think styles are generic enough to work with a |
|
ping @jasonramirez P.S. the latest README and some upcoming changes make these snippets wildly out of date, which presents an even greater opportunity for supporting robust enough styles to make translating the README.md work out. |
|
@seanpdoyle I'll remove the custom styles added by the |
|
@jasonramirez agreed, a separate PR is a good idea. |
| } | ||
|
|
||
| .hljs-symbol { | ||
| .hljs-string { |
There was a problem hiding this comment.
Selector should have depth of applicability no greater than 2, but was 3
