Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy SLO reporter to op1st #817

Closed
goern opened this issue Jan 29, 2021 · 12 comments
Closed

deploy SLO reporter to op1st #817

goern opened this issue Jan 29, 2021 · 12 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@goern
Copy link
Member

goern commented Jan 29, 2021

Is your feature request related to a problem? Please describe.
deploy slo reporter to op1st env cnv-prod, disable it for stage (or limit recipients to aicoe-thoth)

/sig devops
/sig slo
/assign @pacospace

@goern goern added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 29, 2021
@pacospace
Copy link
Contributor

It should be deployed: https://github.com/operate-first/argocd-apps/blob/main/overlays/moc/thoth/prod/prod-thoth-slo-reporter.yaml, not sure why it is missing in thoth-infra-prod, cc @harshad16

@pacospace
Copy link
Contributor

pacospace commented Jan 29, 2021

It should be deployed: https://github.com/operate-first/argocd-apps/blob/main/overlays/moc/thoth/prod/prod-thoth-slo-reporter.yaml, not sure why it is missing in thoth-infra-prod, cc @harshad16

Ok found, we didn't add it to the kustomize.yaml, I guess because we didn't want it there running yet!

@pacospace
Copy link
Contributor

pacospace commented Jan 29, 2021

It should be deployed: https://github.com/operate-first/argocd-apps/blob/main/overlays/moc/thoth/prod/prod-thoth-slo-reporter.yaml, not sure why it is missing in thoth-infra-prod, cc @harshad16

Found is missing in the kustomize file.

Opened PR, but the version we want in production is v0.8.2 not before!, should we just change that component for prod? Or do we need a new date release before moving all to production?

@goern
Copy link
Member Author

goern commented Jan 30, 2021

It should be deployed: https://github.com/operate-first/argocd-apps/blob/main/overlays/moc/thoth/prod/prod-thoth-slo-reporter.yaml, not sure why it is missing in thoth-infra-prod, cc @harshad16

Found is missing in the kustomize file.

Opened PR, but the version we want in production is v0.8.2 not before!, should we just change that component for prod? Or do we need a new date release before moving all to production?

I think with #819 being merged the question is answered?!

@pacospace
Copy link
Contributor

It should be deployed: https://github.com/operate-first/argocd-apps/blob/main/overlays/moc/thoth/prod/prod-thoth-slo-reporter.yaml, not sure why it is missing in thoth-infra-prod, cc @harshad16

Found is missing in the kustomize file.

Opened PR, but the version we want in production is v0.8.2 not before!, should we just change that component for prod? Or do we need a new date release before moving all to production?

I think with #819 being merged the question is answered?!

That was one step required to make sure we have correct version and CM.

Second step: operate-first/argocd-apps#59

@harshad16
Copy link
Member

The slo-reporter is successfully deployed in the op1st cluster.
https://argocd-server-argocd.apps.cnv.massopen.cloud/applications/prod-thoth-slo-reporter?conditions=false

Please close the issue, if this feels satisfactory :)

@pacospace
Copy link
Contributor

The slo-reporter is successfully deployed in the op1st cluster.
https://argocd-server-argocd.apps.cnv.massopen.cloud/applications/prod-thoth-slo-reporter?conditions=false

Please close the issue, if this feels satisfactory :)

Thanks @harshad16 , I still cannot see applications in Argo CD!

@pacospace
Copy link
Contributor

pacospace commented Feb 1, 2021

There is one bug we never encountered in test/stage: thoth-station/slo-reporter#188. I will work on it

@pacospace
Copy link
Contributor

pacospace commented Feb 2, 2021

There is one bug we never encountered in test/stage: thoth-station/slo-reporter#188. I will work on it

Bug has been solved with new release and in prod is running correctly. There is a non critical issue, that it's not priority but I will try to add that as well, so we don't have that issue anymore.

#842

@pacospace
Copy link
Contributor

This might be the next thing to have: thoth-station/slo-reporter#197

@harshad16
Copy link
Member

Bug has been solved with new release and in prod is running correctly. There is a non critical issue, that it's not priority but I will try to add that as well, so we don't have that issue anymore.

The apps is in the place https://console-openshift-console.apps.cnv.massopen.cloud/k8s/ns/thoth-infra-prod/cronjobs/slo-reporter

@pacospace if this feels good enough , can we close this issue?

@pacospace
Copy link
Contributor

Bug has been solved with new release and in prod is running correctly. There is a non critical issue, that it's not priority but I will try to add that as well, so we don't have that issue anymore.

The apps is in the place https://console-openshift-console.apps.cnv.massopen.cloud/k8s/ns/thoth-infra-prod/cronjobs/slo-reporter

@pacospace if this feels good enough , can we close this issue?

Yes we can close it definitely, thanks @harshad16 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants