Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace JamesIves/github-pages-deploy-action by actions/deploy-pages #133

Open
2 tasks
thomvaill opened this issue Oct 30, 2024 · 2 comments
Open
2 tasks
Labels
good first issue Good for newcomers maintenance Maintenance tasks

Comments

@thomvaill
Copy link
Owner

thomvaill commented Oct 30, 2024

Probably better to use the official Github actions, which does not involve the use of another branch anymore.

  • In .github/workflows/on-merge-to-develop.yml
  • In our README.md example if it works correctly
@mervyn-mccreight
Copy link

mervyn-mccreight commented Nov 4, 2024

I'd be interested in contributing here.

Using the deploy-pages action might need some configuration in the pages-settings of the repository which I'd not be able to do myself though (I think the steps needed are configuring "GitHub Actions" as build & deployment source for pages and I'm not sure whether this happens automatically after configuring that or if it has to be done manually, but one might need to create an environment named "github-pages").

@thomvaill
Copy link
Owner Author

Cool!

Yes you can submit a PR and then I'll update these settings:
image

I'll switch to "Use GitHub Actions"

Thank you for your help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers maintenance Maintenance tasks
Projects
None yet
Development

No branches or pull requests

2 participants