Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

html comments containing reference link defentions crash clientside renderer #111

Open
anabelle2001 opened this issue Aug 12, 2023 · 0 comments
Open

html comments containing reference link defentions crash clientside renderer #111

anabelle2001 opened this issue Aug 12, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@anabelle2001
Copy link

anabelle2001 commented Aug 12, 2023 •
edited
Loading

Bug Report:

Description

HTML comments containing reference link definitions crash the preview window

Steps to Reproduce

  1. Add the following comment to anywhere in an ADR.
    <!--[^1]:https://example.com -->
  2. Open the ADR with log4brains preview / Reload the ADR if it's already open

Expected Behavior

Renderer does not crash, and also does not display commented text

Context

I was commenting out a reference link definition with my IDE. This issue came up when trying to do research to make a feature request to fully support reference links, including non-/\^[0-9]+/ shortcut reference links and implict reference links.

Environment

  • Log4brains version: 1.0.1
  • Node.js version: 18.16.1
  • OS and its version: Fedora 38
  • Browser information: Firefox 116.0
@anabelle2001 anabelle2001 added the bug Something isn't working label Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anabelle2001