Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check's attributes not escaped properly #4

Open
goblin opened this issue Oct 18, 2012 · 0 comments
Open

Check's attributes not escaped properly #4

goblin opened this issue Oct 18, 2012 · 0 comments

Comments

@goblin
Copy link

goblin commented Oct 18, 2012

If your noit check contains xml-unsafe characters like < or > (which can easily occur in http body checks), it all breaks:

<?xml version="1.0" encoding="utf8"?>
<error>xml parse error</error>

That's because they're not escaped at https://github.com/thommay/hobelar/blob/master/lib/hobelar.rb#L41

I tried to fix it by writing a test first (even though there aren't any tests yet), but it appears that WebMock is broken too: bblimke/webmock#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@goblin