Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE REQUEST: Automatically change hires fix resoultions too #24

Open
tusharbhutt opened this issue Mar 24, 2023 · 6 comments
Open
Labels
enhancement New feature or request

Comments

@tusharbhutt
Copy link

Thanks for the the neat extension! Is it possible that when you flip aspect ration for the HxW that it could also change the HxW of the Hires,fix too?

@thomasasfk thomasasfk added the enhancement New feature or request label Mar 24, 2023
@thomasasfk
Copy link
Owner

Ah. This is an oversight, well spotted! I'll give it a try when I have time. Thanks for raising.

@thomasasfk
Copy link
Owner

Hey @tusharbhutt - this seems to already work when I try it, can you clarify what you mean?

@tusharbhutt
Copy link
Author

Hey @tusharbhutt - this seems to already work when I try it, can you clarify what you mean?

Sure! When the "Upscale by" in Hires is picked, the resolutions do change:

image

But when the output resolution is set with "resize X to", it does not change:

image

I thought that perhaps if the hires output was set to 1024x1536 and the ratio changed to 16:9, then the hires output would be set to 1536x864. The input resolution does change under height and width, but not under the ones for Hires.fix

@thomasasfk
Copy link
Owner

Ah! thank you very much, that makes it more clear. I'll see when I have time to fix this!

@thomasasfk
Copy link
Owner

Planning on taking a look a this tomorrow as I have some time, will see how difficult it is! Sorry for the delays.

@thomasasfk
Copy link
Owner

This is definitely possible, however a bit of a speedbump is that it's considered disabled when it's 0 - I think I'll need to parameterise the minimum values to allow for it to be 0 as opposed to 64 which is used by the other ones. Not sure when I'll have time to sit down and fully implement it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants