Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework ramparts / walls scaling #143

Open
thmsndk opened this issue May 12, 2020 · 17 comments
Open

Rework ramparts / walls scaling #143

thmsndk opened this issue May 12, 2020 · 17 comments
Labels
enhancement New feature or request question Further information is requested

Comments

@thmsndk
Copy link
Owner

thmsndk commented May 12, 2020

Currently we scale walls and rampart heights depending on a percentage based on their max capacity.

Quotes from slack, bringing the discussion to github.

it gives some clue about how high fortifications are, however most of the time it looks ridiculous

We previously talked about connected ramparts, and them being a forcefield of a kind instead. perhaps emission could be used to determine how fortified it is?
Not sure what we would do about walls though

it could be scaling on some curve (to be determined) instead of linearly, or we could just not scale them at all in favor of them always looking good and fancy

minerals size for an example scale in a non linear fashion as well.

Let's get some ideas / talk going on this subject.

@thmsndk thmsndk added enhancement New feature or request question Further information is requested labels May 12, 2020
@thmsndk
Copy link
Owner Author

thmsndk commented May 12, 2020

I'm not sure in general how full ramparts / walls are. but perhaps they should be higher?

Most often I just see a little bit of height on them. but what is the current max height of walls / ramparts. should that perhaps be increased? I don't know how often a wall is at full capacity.

But they for sure don't really feel like walls currently. e.g. a creep is almost the same height as them :P

@Gadjung
Copy link

Gadjung commented May 12, 2020

some cheap volumetrics ?
problem with emission is that to be properly visible and look good it needs to be quite strong

@Robalian
Copy link
Collaborator

They scale from 1 to 300M on RCL8 so we can't really show accurately show their hits using height. We could use nonlinear scale, but then at which point should it flat out?
I feel like ramparts should always be able to cover structure/creep, providing protection and so on, and walls should be the same size.t they're that size.
I'm not a fan of showing their strength by emission and it doesn't really solve anything as we'll run into the same issue of it looking good only in specific value range.

@Gadjung
Copy link

Gadjung commented May 12, 2020

as long as You can click it and get info i agree with just covering cell

@thmsndk
Copy link
Owner Author

thmsndk commented May 12, 2020

@Robalian what if walls where higher, that would give more range to play with?

I feel ramparts should be a forcefield that covers everything on the tile, and probably connected with the other tiles. Not sure how we would show the strength of the rampart. But I like this effect

https://youtu.be/NiOGWZXBg4Y

@Gadjung
Copy link

Gadjung commented Jun 14, 2020

https://www.wolframalpha.com/input/?i=Ceiling%28log%28Ceiling%28x%2F1000%29%29%29*.3+%2B+0.1+from+1+to+300000000

this formula seems promising for adjusting rampart height - > will also check if it can be nicely applied to walls

@Gadjung Gadjung mentioned this issue Jun 16, 2020
@Gadjung
Copy link

Gadjung commented Jul 25, 2020

i think it can be closed ?

@kurtish
Copy link

kurtish commented Jul 26, 2020

What are your thought on wall thickness instead of height as an indicator of strength?

So you could make walls and ramparts shorter so they look nice and not so long and un-wieldly so they aesthetically look nice. So this way the more hits a wall or rampart has, we represent this by making the wall thicker?

@thmsndk
Copy link
Owner Author

thmsndk commented Jul 26, 2020

I like the idea, but i'm not sure if we can show "thickness" properly? I assume you also wanted this to happen for ramparts?

The issue being ramparts needs to be transparant and a "forcefield" for us to be able to see what is inside it 🤔

@Gadjung
Copy link

Gadjung commented Jul 26, 2020

problem is that we would need to kinda guess which way thicker (either on X or Y axis)
also ramparts needs to be rectangular to cover the whole cell they protect (and then showing 'thickness' is limited and not much visible)

@kurtish
Copy link

kurtish commented Jul 26, 2020

Ahh right, we would need logic that was not needed before, great point.

@kurtish
Copy link

kurtish commented Jul 26, 2020

Ok, Here is Thickness V2. HAHAH

Since Gadjung had a good point that if it was thickness, you would need to determine what X/Y direction to start with to fill the Tile Properly.

What if the Walls and Ramparts started Hollow. So the outside Shell of a Wall or Rampart Still fills the whole square, but was hollow like an empty box. The more hits a wall/Rampart has the more the box walls thicken.

So at 100% all 4 sides would meet in the middle forming a filled piece of Rampart or filled in forcefield Rampart.

This would be fine for how Ramparts are currently a cube, but this approach would need Ramparts to be a mirriored shape on all 4 sides so it could scale on each side to meet in the middle when full and look nice.

Just spitballing :)

@nevercast
Copy link

For walls, I'd like to see them move from light concrete grey to something darker in colour to show fortification. Keep the model the same.

@thmsndk
Copy link
Owner Author

thmsndk commented Jul 27, 2021

For walls, I'd like to see them move from light concrete grey to something darker in colour to show fortification. Keep the model the same.

Currently the height is adjusted to indicate how fortified it is, we have "thresholds" where it scales up / down I actually think the wolram alpha formular linked earlier is used right now

@nevercast
Copy link

Currently the height is adjusted to indicate how fortified it is, we have "thresholds" where it scales up / down I actually think the wolram alpha formular linked earlier is used right now

Is the intention that turrets and links are always taller than walls? Or will their projectiles be parabolic in nature?

@Gadjung
Copy link

Gadjung commented Jul 27, 2021

if nothing changed it's the wolfram alpha formula.
turrets and links have predefined height. parabole just looks a bit better than a straight lazor ray (in my opinion)
(also was adopted from existing code). for Links i was thinking to make it even more steep but for now it's somewhere in backlog.

regarding coloring there's not much grading that can be done between 1 and 300 000 000, and i think grey ramparts might give incorrect notion regarding ownership

@nevercast
Copy link

If you've a formula for height you have a formula for color instead. But if the teams intention is to prefer height then that's fine. Just seems like an unusual indicator since it doesn't matter at all. (Density matters) and it occludes visibility

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants