Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set competitor_limit to NULL when "No competitor limit" is selected in the competition form #10693

Open
dunkOnIT opened this issue Jan 27, 2025 · 2 comments · May be fixed by #10770
Open

Set competitor_limit to NULL when "No competitor limit" is selected in the competition form #10693

dunkOnIT opened this issue Jan 27, 2025 · 2 comments · May be fixed by #10770
Labels
SERVICE: competition TECH: ruby Requires knowledge of Ruby

Comments

@dunkOnIT
Copy link
Contributor

This usually happens by default, but in the case of cloned competitions where they get changed from having a competitor limit to no limit, the integer competitor_limit field remains in the database.
@dunkOnIT dunkOnIT added SERVICE: competition TECH: ruby Requires knowledge of Ruby labels Jan 27, 2025
@pranav-027 pranav-027 linked a pull request Feb 4, 2025 that will close this issue
Open
@gregorbg
Copy link
Member

gregorbg commented Feb 4, 2025

Is this actually causing pains somewhere?
If the enabled field is off, all frontend and backend checks shouldn't even bother looking into the reason field for example

@dunkOnIT
Copy link
Contributor Author

dunkOnIT commented Feb 4, 2025

This recently caused an issue on a multi-location FMC comp, which was cloned from another comp which had a competitor limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
SERVICE: competition TECH: ruby Requires knowledge of Ruby
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set competitor_limit and reason to null after disabling limit pranav-027/worldcubeassociation.org
2 participants
@gregorbg @dunkOnIT