Skip to content

Commit 000633a

Browse files
committed
apause.exp: promote unexpected "PAUSE" feedback from warning to failure
Experience with thesofproject/linux#5109 shows that this warning never seems harmless: the test ends up timing out and failing anyway. So, better failing fast for clearer and better logs. Also increase the log level of press_space() to avoid state confusion. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
1 parent 5f1c37f commit 000633a

File tree

1 file changed

+3
-7
lines changed

1 file changed

+3
-7
lines changed

case-lib/apause.exp

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ proc rel_time_ms {} {
8181

8282
proc press_space {} {
8383
global last_space_time
84-
log 2 "Pressing SPACE"
84+
log 1 "Pressing SPACE"
8585
send " "
8686
set last_space_time [rel_time_ms]
8787
log 3 "last_space_time set to $last_space_time"
@@ -237,12 +237,8 @@ expect {
237237

238238
{=== PAUSE ===} {
239239
if {$state != "pause_requested"} {
240-
# TODO: upgrade this to an ERROR if we want to fix pause bugs like
241-
# https://github.com/thesofproject/linux/issues/5109
242-
# As of July 2024, pause is rather being disabled:
243-
# https://github.com/thesofproject/linux/pull/5041
244-
log 0 "WARNING: received == PAUSE == while in state $state! Ignoring."
245-
exp_continue
240+
log 0 "ERROR: received == PAUSE == while in state $state!"
241+
exit 1
246242
}
247243

248244
set state paused

0 commit comments

Comments
 (0)