Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bagging the peaks #1

Open
zmitton opened this issue Oct 12, 2019 · 0 comments
Open

bagging the peaks #1

zmitton opened this issue Oct 12, 2019 · 0 comments

Comments

@zmitton
Copy link

zmitton commented Oct 12, 2019

Just a small suggestion (having implemented an MMR in a couple languages). Change the algorithm for "bagging the peaks" to instead be simply the hash of the concatenation of all peaks

This allows you to refer to nodes by a definite and unchanging position index, whereas the nodes created during your current bagging process have to be recomputed from scratch every time you add a leaf anyway.

zmitton/merkle-mountain-range#1 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zmitton