Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for empty route paths to be treat as the base route path #322

Open
kimjohans opened this issue Dec 28, 2021 · 2 comments
Open

Allow for empty route paths to be treat as the base route path #322

kimjohans opened this issue Dec 28, 2021 · 2 comments
Labels

Comments

@kimjohans
Copy link

kimjohans commented Dec 28, 2021

Removed request. Please close issue. Thanks.

@kimjohans kimjohans changed the title Bug in path mapping Bug in path mapping (with solution src) Dec 28, 2021
@philipobenito
Copy link
Member

I'll have to double check this in a few days but if I remember correctly it's not expecting an empty route path, by design it's expecting "/" for an empty/base route path and then it would match.

Your proposed change might be considered a breaking change but I'll look in to it more when I'm back on a computer.

@kimjohans kimjohans changed the title Bug in path mapping (with solution src) Optimization in path mapping (with solution src) Dec 30, 2021
@philipobenito
Copy link
Member

Yeah, empty just wasn't considered that's all, something I'll probably account for in the next major version, can't right now as it could change behaviour of other peoples apps

@philipobenito philipobenito changed the title Optimization in path mapping (with solution src) Allow for empty route paths to be treat as the base route path Jan 15, 2022
@philipobenito philipobenito reopened this Jan 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants