From 576f522269e7a675d52c68a4a2f85a994a65f975 Mon Sep 17 00:00:00 2001 From: thepercival Date: Mon, 29 Apr 2024 10:10:34 +0200 Subject: [PATCH] fix(output): package --- composer.lock | 12 ++++++------ domain/Game/Assigner.php | 8 ++++---- tests/helpers/PlanningCreator.php | 2 +- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/composer.lock b/composer.lock index 9653de2..5dbb823 100644 --- a/composer.lock +++ b/composer.lock @@ -2374,16 +2374,16 @@ }, { "name": "thepercival/php-sports-planning", - "version": "v1.0.167", + "version": "v1.0.168", "source": { "type": "git", "url": "https://github.com/thepercival/php-sports-planning.git", - "reference": "c1baba15f12b410ece19c61a9a720fcc86e7dccc" + "reference": "2349a4c7a3a4820009a41a393c4ac4aebcd3103c" }, "dist": { "type": "zip", - "url": "https://api.github.com/repos/thepercival/php-sports-planning/zipball/c1baba15f12b410ece19c61a9a720fcc86e7dccc", - "reference": "c1baba15f12b410ece19c61a9a720fcc86e7dccc", + "url": "https://api.github.com/repos/thepercival/php-sports-planning/zipball/2349a4c7a3a4820009a41a393c4ac4aebcd3103c", + "reference": "2349a4c7a3a4820009a41a393c4ac4aebcd3103c", "shasum": "" }, "require": { @@ -2441,9 +2441,9 @@ "support": { "email": "coendunnink@gmail.com", "issues": "https://github.com/thepercival/php-sports-planning/issues", - "source": "https://github.com/thepercival/php-sports-planning/tree/v1.0.167" + "source": "https://github.com/thepercival/php-sports-planning/tree/v1.0.168" }, - "time": "2024-04-26T18:53:54+00:00" + "time": "2024-04-29T08:02:48+00:00" } ], "packages-dev": [ diff --git a/domain/Game/Assigner.php b/domain/Game/Assigner.php index c7b861c..52df0b5 100644 --- a/domain/Game/Assigner.php +++ b/domain/Game/Assigner.php @@ -23,7 +23,7 @@ public function __construct(protected LoggerInterface $logger) $this->throwOnTimeout = true; } - public function assignGames(Planning $planning): bool + public function assignGames(Planning $planning): PlanningState { $games = (new PreAssignSorter())->getGames($planning); // (new GameOutput($this->logger))->outputGames($games); @@ -46,7 +46,7 @@ public function assignGames(Planning $planning): bool } else { $planning->setTimeoutState(null); } - return false; + return $state; } $firstBatch = $planning->createFirstBatch(); @@ -68,13 +68,13 @@ public function assignGames(Planning $planning): bool $planning->setTimeoutState(null); } $this->logger->error(' could not assign refereeplaces (plId:' . (string)$planning->getId() . ')'); - return false; + return $state; } } $planning->setState(PlanningState::Succeeded); $planning->setTimeoutState(null); $planning->setNrOfBatches($firstBatch->getLeaf()->getNumber()); - return true; + return PlanningState::Succeeded; } public function disableThrowOnTimeout(): void diff --git a/tests/helpers/PlanningCreator.php b/tests/helpers/PlanningCreator.php index ec0f9fa..6cd7f2a 100644 --- a/tests/helpers/PlanningCreator.php +++ b/tests/helpers/PlanningCreator.php @@ -175,7 +175,7 @@ protected function createPlanning( if ($showHighestCompletedBatchNr) { $gameAssigner->showHighestCompletedBatchNr(); } - if( $gameAssigner->assignGames($planning) === false ) { + if( $gameAssigner->assignGames($planning) !== PlanningState::Succeeded ) { throw new Exception("planning could not be created", E_ERROR); } return $planning;