Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Large refactoring to handleEvent #31

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

feat: Large refactoring to handleEvent #31

wants to merge 11 commits into from

Conversation

RDIL
Copy link
Member

@RDIL RDIL commented Jul 25, 2024

Refactoring handleEvent such that it's not all one giant function.

Other stuff:

  • Refactor logging into a cleaner solution
  • Add a test for contract ID stuff
  • Handle pre-exec actions (should fix Support $ event #7)
  • Renamed some types

InStateEventHandler doesn't really describe what it is to an outsider, now it's called CATObject (conditions, actions, transition)

@RDIL RDIL added the enhancement New feature or request label Jul 25, 2024
@RDIL RDIL requested a review from AnthonyFuller July 25, 2024 01:31
@codecov Codecov
Copy link

codecov bot commented Jul 25, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 92.56506% with 20 lines in your changes missing coverage. Please review.

Files Coverage Δ
src/index.ts 96.39% <100.00%> (+0.03%) ⬆️
src/logging.ts 100.00% <100.00%> (ø)
src/types.ts 100.00% <100.00%> (ø)
src/utils.ts 100.00% <100.00%> (ø)
tests/timers.spec.ts 100.00% <100.00%> (ø)
src/handleEvent.ts 86.55% <89.84%> (+0.50%) ⬆️

@RDIL RDIL changed the base branch from main to any-object July 25, 2024 01:36
@RDIL RDIL changed the base branch from any-object to main July 25, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyFuller AnthonyFuller Awaiting requested review from AnthonyFuller

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support $ event
1 participant
@RDIL