Skip to content
This repository has been archived by the owner on Feb 13, 2019. It is now read-only.

compatibility with Videojs 5 ? #86

Open
DrLightman opened this issue Oct 12, 2015 · 17 comments
Open

compatibility with Videojs 5 ? #86

DrLightman opened this issue Oct 12, 2015 · 17 comments

Comments

@DrLightman
Copy link

Any hope/tweak in order to see this working with the latest Videojs 5 ?

Thank you

@alfuken
Copy link

alfuken commented Oct 20, 2015

+1 for that

@oleynikd
Copy link

oleynikd commented Nov 6, 2015

+1
Where is the source? We could help to port it...

@svetlin-mladenov
Copy link

+1

3 similar comments
@trucle
Copy link

trucle commented Dec 28, 2015

+1

@halibegic
Copy link

+1

@tarikdedic
Copy link

+1

@joshmadewell
Copy link

Pretty sure this project is dead. I would consider using https://github.com/MailOnline/videojs-vast-vpaid/

@wmcmurray
Copy link

👆 The above alternative does not currently support 5.x either... BUT there is some sort of progress going on in this issue : MailOnline/videojs-vast-vpaid#74

@philipgiuliani
Copy link

#87 You can use this code! Its working very well with VJS 5

@wmcmurray
Copy link

I wrote a blog article about which ads plugin to choose (and the perfect one is not mentioned here!).. I'll try to keep it up to date if things changes but for now, spare yourself some pain and read it !

@DrLightman
Copy link
Author

@wmcmurray
thanks for pointing that article out, I'm having issues with MailOnline plugin indeed and I'm looking for an alternative.

edit: maybe not the right place to to this, but I'm getting this error after setupping a simple test with your suggested videojs-ima plugin for videojs:

TypeError: player.ads is not a function in videojs.ima.js line 1128

edit2: oh boy, AdBlockPlus was blocking the videojs.ads.* files, solved. I feel ashamed.

@prock13
Copy link

prock13 commented Mar 20, 2016

@wmcmurray thanks for the write up...just saved me hours of trying to figure out why videojs-vast wasn't working for me. Question for you: Have you tried using videojs-ima with videojs-youtube? I'd like to serve up some youtube videos and deliver my own pre-rolls.

@wmcmurray
Copy link

@prock13 I'm very glad it helped ! I haven't tried it with videojs-youtube but if you are unable to make it work, just tell me, I could take a look.

@prock13
Copy link

prock13 commented Mar 21, 2016

@wmcmurray Thanks...I couldn't get it to work and I'm thinking it's because it only works with an older version of videojs but I'm not sure.

@wmcmurray
Copy link

@prock13 You should be using VideoJS v5.x, it works with my suggested ads plugin since npm release 0.4.0 (note that for some reason, there is no github release tag for this version right now, code on master branch should be okay if you are not using npm). And if your videojs-youtube plugin is this one, their readme says :

Use branch vjs4 if you still using old VideoJS v4.x.

so I guess it works with v5.x 😉

@MiyuMew
Copy link

MiyuMew commented Mar 31, 2016

Hi @wmcmurray,

Thanks for your article.
I try too to put preroll add on youtube video using IMA & Videojs but that seems impossible. In IMA SDK they said "Publishers cannot use IMA products to monetize YouTube-hosted content. For YouTube content, publishers must monetize through the YouTube partner program.".

No solutions for that so :/

@feelslikefriday
Copy link

Any news on this? I tried to use this plugin with video.js v. 5.11 and it throws this error:
TypeError: undefined is not an object (evaluating 'vjs.Html5.Events') videojs.ads.js:474

(or is that me doing something silly?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests