Skip to content

Commit ab1f806

Browse files
authored
Merge pull request #6 from base2Services/feature/update-standards
Feature/update standards
2 parents b970717 + ab611a3 commit ab1f806

File tree

4 files changed

+16
-6
lines changed

4 files changed

+16
-6
lines changed

rds-mysql.cfhighlander.rb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66

77
Parameters do
88
ComponentParam 'VPCId', type: 'AWS::EC2::VPC::Id'
9+
ComponentParam 'NetworkPrefix', isGlobal: true
910
ComponentParam 'StackOctet', isGlobal: true
1011
ComponentParam 'RDSSnapshotID'
1112
ComponentParam 'MultiAZ', 'false', allowedValues: ['true','false']
@@ -14,8 +15,6 @@
1415
ComponentParam 'RDSInstanceType'
1516
ComponentParam 'RDSAllocatedStorage'
1617
ComponentParam 'DnsDomain'
17-
maximum_availability_zones.times do |az|
18-
ComponentParam "SubnetPersistence#{az}"
19-
end
18+
ComponentParam 'SubnetIds', type: 'CommaDelimitedList'
2019
end
2120
end

rds-mysql.cfndsl.rb

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,6 @@
22

33
Description "#{component_name} - #{component_version}"
44

5-
az_conditions_resources('SubnetPersistence', maximum_availability_zones)
6-
75
tags = []
86
tags << { Key: 'Environment', Value: Ref(:EnvironmentName) }
97
tags << { Key: 'EnvironmentType', Value: Ref(:EnvironmentType) }
@@ -19,7 +17,7 @@
1917

2018
RDS_DBSubnetGroup 'SubnetGroupRDS' do
2119
DBSubnetGroupDescription FnJoin(' ', [ Ref(:EnvironmentName), component_name, 'subnet group' ])
22-
SubnetIds az_conditional_resources('SubnetPersistence', maximum_availability_zones)
20+
SubnetIds Ref(:SubnetIds)
2321
Tags tags + [{ Key: 'Name', Value: FnJoin('-', [ Ref(:EnvironmentName), component_name, 'subnet-group' ])}]
2422
end
2523

tests/default.test.yaml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
test_metadata:
2+
type: config
3+
name: default
4+
description: default test with base configuration
5+
6+
# Insert your tests here

tests/parameters.test.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
test_metadata:
2+
type: config
3+
name: parameters
4+
description: set setting parameters in parameter group
5+
6+
parameters:
7+
authentication_timeout: '60'

0 commit comments

Comments
 (0)