handle SnapshotArns as a list of strings better

Author: aaronwalker

redis.cfhighlander.rb

@@ -18,7 +18,7 @@
     ComponentParam 'SnapshotName', '',
       description: 'The name of a snapshot from which to restore data into the new replication group'
 
-      ComponentParam 'SnapshotArns', '', type: 'CommaDelimitedList',
+      ComponentParam 'SnapshotArns', '',
         description: 'A list of ARNs that uniquely identify the Redis RDB snapshot files stored in S3'
 
     ComponentParam 'SnapshotRetentionLimit',

redis.cfndsl.rb

@@ -114,7 +114,7 @@
     end 
 
     SnapshotName FnIf('NoSnapshotNamEnabled', Ref('AWS::NoValue'), Ref(:SnapshotName))
-    SnapshotArns FnIf('NoSnapshotArnsEnabled', Ref('AWS::NoValue'), Ref(:SnapshotArns))
+    SnapshotArns FnIf('NoSnapshotArnsEnabled', Ref('AWS::NoValue'), FnSplit(",", Ref(:SnapshotArns)))
     SnapshotRetentionLimit Ref(:SnapshotRetentionLimit)
 
     SnapshotWindow snapshot_window unless snapshot_window.nil?

spec/cache-cluster_spec.rb

@@ -27,7 +27,7 @@
         "NumCacheClusters" => {"Ref"=>"NumCacheClusters"},
         "ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
         "SecurityGroupIds" => [{"Ref"=>"SecurityGroupRedis"}],
-        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotArns"}]},
+        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Fn::Split" => [",", {"Ref" => "SnapshotArns"}]}]},
         "SnapshotName" => {"Fn::If" => ["NoSnapshotNamEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotName"}]},
         "SnapshotRetentionLimit" => {"Ref"=>"SnapshotRetentionLimit"},
         "Tags" => [

spec/clustered_spec.rb

@@ -30,7 +30,7 @@
         "ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
         "ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
         "SecurityGroupIds" => [{"Ref"=>"SecurityGroupRedis"}],
-        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotArns"}]},
+        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Fn::Split" => [",", {"Ref" => "SnapshotArns"}]}]},
         "SnapshotName" => {"Fn::If" => ["NoSnapshotNamEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotName"}]},
         "SnapshotRetentionLimit" => {"Ref"=>"SnapshotRetentionLimit"},
         "SnapshotWindow" => "00:30-02:30",

spec/default_spec.rb

@@ -28,7 +28,7 @@
         "ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
         "ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
         "SecurityGroupIds" => [{"Ref"=>"SecurityGroupRedis"}],
-        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotArns"}]},
+        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Fn::Split" => [",", {"Ref" => "SnapshotArns"}]}]},
         "SnapshotName" => {"Fn::If" => ["NoSnapshotNamEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotName"}]},
         "SnapshotRetentionLimit" => {"Ref"=>"SnapshotRetentionLimit"},
         "Tags" => [

spec/node-group_spec.rb

@@ -28,7 +28,7 @@
         "ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
         "ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
         "SecurityGroupIds" => [{"Ref"=>"SecurityGroupRedis"}],
-        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotArns"}]},
+        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Fn::Split" => [",", {"Ref" => "SnapshotArns"}]}]},
         "SnapshotName" => {"Fn::If" => ["NoSnapshotNamEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotName"}]},
         "SnapshotRetentionLimit" => {"Ref"=>"SnapshotRetentionLimit"},
         "Tags" => [

spec/non-clustered_spec.rb

@@ -28,7 +28,7 @@
         "ReplicasPerNodeGroup" => {"Ref"=>"ReplicasPerNodeGroup"},
         "ReplicationGroupDescription" => {"Fn::Sub"=>"${EnvironmentName}-redis"},
         "SecurityGroupIds" => [{"Ref"=>"SecurityGroupRedis"}],
-        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotArns"}]},
+        "SnapshotArns" => {"Fn::If" => ["NoSnapshotArnsEnabled", {"Ref" => "AWS::NoValue"}, {"Fn::Split" => [",", {"Ref" => "SnapshotArns"}]}]},
         "SnapshotName" => {"Fn::If" => ["NoSnapshotNamEnabled", {"Ref" => "AWS::NoValue"}, {"Ref" => "SnapshotName"}]},
         "SnapshotRetentionLimit" => {"Ref"=>"SnapshotRetentionLimit"},
         "Tags" => [