Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VpcConfig property for lambda functions in lambda_helper #82

Open
Guslington opened this issue Jan 7, 2019 · 4 comments
Open

Add VpcConfig property for lambda functions in lambda_helper #82

Guslington opened this issue Jan 7, 2019 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@Guslington
Copy link
Member

No description provided.

@toshke toshke self-assigned this Jan 14, 2019
@toshke toshke added the enhancement New feature or request label Jan 14, 2019
@toshke
Copy link
Member

toshke commented Jan 14, 2019

There will be 3 supported modes

  1. for out-of-the-box functionality auto will be supported as vpc property value for lambda config
  2. for fine-tuning, and providing other than compute subnets, following format shall be used:
  3. Tweak of the previous mode
# Example1:  Pull Subnets from VPC Component automatically
lambdas:
  function1:
     vpc: auto
# Example2: Define your own security groups
lambdas:
  function1:
     vpc:
        subnets: <SUBNETDEFINITIONHERE>
        secgroups: <SECURITYGROUPSDEFINITIONHERE>
# Example3: Define security groups on group of functions
lambdas:
  vpc: auto  | example2 above
  functions:
    func1:
     ...
    func2:

@aaronwalker @Guslington let me know what you think on the format

@toshke
Copy link
Member

toshke commented Jan 14, 2019

If auto mode is used, component rendering lambdas will need to have dependency on vpc (that is, az_conditional_resources function defined.

@toshke
Copy link
Member

toshke commented Jan 14, 2019

@Guslington @aaronwalker implementation for auto behaviour can be found on feature branch on my fork

Instructions for testing can be found at https://github.com/toshke/hl-component-vpc-lambdas

@Guslington
Copy link
Member Author

@toshke what about passing around the subnets using List<AWS::EC2::Subnet::Id> ? I'm going to do some testing with this in other components to see if we can drop the dependency of the vpc component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants