Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for stack dependson when inlining a component #174

Open
aaronwalker opened this issue Aug 4, 2021 · 1 comment
Open

Support for stack dependson when inlining a component #174

aaronwalker opened this issue Aug 4, 2021 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@aaronwalker
Copy link
Member

Right now when we have component like

CfhighlanderTemplate do

  Parameters do
    ComponentParam 'RegionCode', 'eu', allowedValues: ['eu', 'us', 'ap']
  end

  Component template: 'a', name: 'a1', render: Inline do
    parameter name: 'RegionCode', value: Ref('RegionCode')
  end

  Component template: 'a', name: 'a2', dependson: ['a1'] do
    parameter name: 'RegionCode', value: Ref('RegionCode')
  end
    
end

We end up with an invalid DependsOn referencing the name of the inlined stack which has been removed.

Ideally it would be good to be able to reference a specific resource within the inlined stack maybe we could support for following syntax for dependson

  Component template: 'a', name: 'a2', dependson: ['a1.SnsTopic'] do
    parameter name: 'RegionCode', value: Ref('RegionCode')
  end

and the resulting DependsOn would just contain the reference to the inlined resource

@Guslington @toshke thoughts????

@aaronwalker aaronwalker added the enhancement New feature or request label Aug 4, 2021
@toshke
Copy link
Member

toshke commented Aug 5, 2021

I believe I chucked this use cae in "too hard" basket when initially working on inlining, though the behaviour you described does reflect what I would expect it to behave.

@tarunmenon95 tarunmenon95 self-assigned this Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants