Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for building a Container Images and pushing to ECR for use with Lambda or ECS #171

Open
aaronwalker opened this issue Aug 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@aaronwalker
Copy link
Member

aaronwalker commented Aug 2, 2021

This feature is kinda similar to LambdaFunctions in that it allows custom code to be package and deployed with the generated cloudformation but with support for building and publishing container images.

Use Case: Creating more application specific components and services. For example a component for deploying a running ProxySQL Rather than relying on public container images have the component include all the dependencies (Dockerfile, config etc)

Add a new operation to the highlander dsl to build and publish a container image

Something like

ContainerImage image_name: proxysql, dockerfile: 'Dockerfile', ecr_repo: '1234567890.dkr.ecr.eu-central-1.amazonaws.com'

During the compile stage highlander would run a docker build and docker push to ecr and would create the ecr repo if it didn't exist with options for setting the permissions for the ecr_repo

@aaronwalker aaronwalker added the enhancement New feature or request label Aug 2, 2021
@aaronwalker
Copy link
Member Author

@Guslington @Samseppiol @toshke thoughts?

@toshke
Copy link
Member

toshke commented Aug 3, 2021

I like the feature and it will move the tool into more hybrid category where it's not necessary used only for infrastructure code, but also for deployment of other related artifacts - which already do with S3 publish function to extent.

Looking at CDK this feature seems to be supported as well as in Pulumi

Kinda goes against "single tool for single job" unix philosophy, but that's probably just my ocd speaking more than anything.

Also, in definition you would probably want args: and context: keyword parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants