Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support publishing additional artifacts #165

Open
aaronwalker opened this issue Jun 2, 2021 · 2 comments
Open

Support publishing additional artifacts #165

aaronwalker opened this issue Jun 2, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@aaronwalker
Copy link
Member

aaronwalker commented Jun 2, 2021

I would be useful to be able to include additional artifacts in the S3 publish for components.

Use Case: The api gateway component supports loading a api swagger file from S3 so it would be useful to just include the api swagger definition is the published templates instead of requiring an additional deployment step

maybe something like

PublishArtifact file: "my-swagger.yaml", key: "my-swagger-#{component_version}.yaml"

or

S3Artifact file: "my-swagger.yaml", key: "my-swagger-#{component_version}.yaml"

The key could be optional

@aaronwalker aaronwalker added the enhancement New feature or request label Jun 2, 2021
@aaronwalker
Copy link
Member Author

@Guslington @toshke thoughts?

@Guslington
Copy link
Member

@aaronwalker would it be worth exposing the artifact key value to a component

Api:
    Type: AWS::ApiGateway::RestApi
    Properties: 
    BodyS3Location: 
        Bucket: distribution_bucket
        Key: artifact_key['name']

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants