Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip validation of compiled inlined templates #155

Open
Guslington opened this issue Jul 10, 2020 · 0 comments
Open

Skip validation of compiled inlined templates #155

Guslington opened this issue Jul 10, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@Guslington
Copy link
Member

When a sub component inlines another component all templates compiled are validated which can sometimes lead to validation errors of templates that are not required as they've been inlined.

for example the fargate-v2 component inlines the ecs-task component. If add a custom parameter to the fargate-v2 component that's used in the task definition, validation for the ecs-task template fails because it doesn't have the parameter.

However there is no point in validating the ecs-task template as it's been inlined into the fargate template.
I think we should delete all inlined templates before validation

@Guslington Guslington added the bug Something isn't working label Jul 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant