Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support eglot as well as lsp-mode #3

Open
mdbergmann opened this issue Oct 11, 2024 · 1 comment
Open

Support eglot as well as lsp-mode #3

mdbergmann opened this issue Oct 11, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@mdbergmann
Copy link

Hello.
Great project.
Just wondering, since Eglot is basically standard Emacs LSP client, and I use it a lot, can Eglot also be used?

@themkat themkat changed the title Is lsp-mode a hard dependency? Support eglot as well as lsp-mode Oct 12, 2024
@themkat
Copy link
Owner

themkat commented Oct 12, 2024

At the moment, there are a few places that depend on lsp-mode. AFAIK, that can easily be fixed! 🙂 Renaming this task to "remove hard dependency on lsp-mode". If you have any suggestions on how to easily support both, I'm all ears 🙂 atm, my idea is to let the user require the correct one, i.e, (require 'lsp-m68k) if using lsp-mode, or (require 'm68k-eglot) if using eglot. That way seems the simplest implementation-wise without any error prone toggles.

The reason for me using lsp-mode as a default is that I didn't enjoy eglot at all when I tried it. I enjoy the way lsp-mode does things, but I'm probably biased due to contributing to it.

@themkat themkat added the enhancement New feature or request label Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants