shiro.ini setup ignores REAPER_SHIRO_INI variable when appending REAPER_AUTH_USER and uses default path #1512

santiago-requena-despegar · 2024-07-05T12:02:51Z

Even though the configured variable for shiro.ini is effectively used as a config when set:

cassandra-reaper/src/server/src/main/docker/configure-webui-authentication.sh

Lines 20 to 26 in 92ddde6

    
           if [ ! -z "${REAPER_SHIRO_INI}" ]; then 
        
           cat <<EOT >> /etc/cassandra-reaper/config/cassandra-reaper.yml 
        
           accessControl: 
        
             sessionTimeout: PT10M 
        
             shiro: 
        
               iniConfigs: ["file:${REAPER_SHIRO_INI}"] 
        
           EOT

Custom users specified through REAPER_AUTH_USER will be appended regardless to the default /etc/cassandra-reaper/config/shiro.ini path instead of either using the custom path or doing nothing.

cassandra-reaper/src/server/src/main/docker/configure-webui-authentication.sh

Lines 43 to 47 in 92ddde6

    
           if [ ! -z "${REAPER_AUTH_USER}" ]; then 
        
           cat <<EOT2 >> /etc/cassandra-reaper/config/shiro.ini 
        
           ${REAPER_AUTH_USER} = ${REAPER_AUTH_PASSWORD}, operator 
        
           EOT2 
        
           fi

Maybe not a bug per se, but it makes intent ambiguous regarding the purpose of the REAPER_AUTH_USER variable when REAPER_SHIRO_INI is set to a non-default value.

┆Issue is synchronized with this Jira Story by Unito
┆Issue Number: REAP-6

The text was updated successfully, but these errors were encountered:

santiago-requena-despegar linked a pull request Jul 5, 2024 that will close this issue

Update configure-webui-authentication.sh, using the custom path #1513

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

shiro.ini setup ignores REAPER_SHIRO_INI variable when appending REAPER_AUTH_USER and uses default path #1512

shiro.ini setup ignores REAPER_SHIRO_INI variable when appending REAPER_AUTH_USER and uses default path #1512

santiago-requena-despegar commented Jul 5, 2024 •

edited by sync-by-unito bot

Loading

shiro.ini setup ignores REAPER_SHIRO_INI variable when appending REAPER_AUTH_USER and uses default path #1512

shiro.ini setup ignores REAPER_SHIRO_INI variable when appending REAPER_AUTH_USER and uses default path #1512

Comments

santiago-requena-despegar commented Jul 5, 2024 • edited by sync-by-unito bot Loading

santiago-requena-despegar commented Jul 5, 2024 •

edited by sync-by-unito bot

Loading