Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More meaningful charging state #12

Open
kifort opened this issue Dec 8, 2021 · 1 comment
Open

More meaningful charging state #12

kifort opened this issue Dec 8, 2021 · 1 comment

Comments

@kifort
Copy link

kifort commented Dec 8, 2021

Wrong packet ID is used for battery voltage at

roomba.getSensors(21, tempBuf, 1);

Packet ID 21 is the Charging State
Packet ID 22 is the Voltage

It is only a variable naming issue, but the integer value of Packet ID 21 can be mapped to a more meaningful name based on the Code and Charging State mapping.

@pilot1981
Copy link

I agree with you! You can suggest a pullrequest to this code? I don’t think @thehookup can review its code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants