Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding output with action result #50

Open
karpikpl opened this issue May 6, 2024 · 4 comments · May be fixed by #51
Open

Adding output with action result #50

karpikpl opened this issue May 6, 2024 · 4 comments · May be fixed by #51

Comments

@karpikpl
Copy link

karpikpl commented May 6, 2024

I think having output variable with the check results would be useful to chain more actions, e.g. add a PR comment.

I could do a PR for it if you're open to having this feature.
@thehanimo
Copy link
Owner

Would this be a single Boolean? Or something like #30?

@karpikpl
Copy link
Author

karpikpl commented May 8, 2024

I was thinking about Boolean, I saw #30 and thought it might not be that easy to handle.
In the workflow I was doing, I wanted to add a comment with explanation on what titles are accepted.

Triggering of label change doesn't work when GITHUB_TOKEN is used, so a simple true/false result would help

@thehanimo
Copy link
Owner

Sure, if you could create a PR that'd be great. This should be backwards compatible right?

@karpikpl
Copy link
Author

karpikpl commented May 8, 2024

that's right, using outputs is optional and doesn't change how action is executed

@karpikpl karpikpl linked a pull request May 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding output to show if check succeeded or failed karpikpl/pr-title-checker
2 participants
@karpikpl @thehanimo