Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createSimulation auth0 client_id vs clientId #124

Open
jbolda opened this issue Aug 18, 2021 · 1 comment
Open

createSimulation auth0 client_id vs clientId #124

jbolda opened this issue Aug 18, 2021 · 1 comment

Comments

@jbolda
Copy link
Contributor

jbolda commented Aug 18, 2021

createSimulation expects a clientId, but it seems there is prior art to client_id and we may want to consider migrating.

the auth0 config uses client_id and it is a source of bugs (I've done it) by passing in clientId and not client_id. I think I would rename ours to client_id and be done with it.

reference: #114 (comment)

@dagda1
Copy link
Contributor

dagda1 commented Aug 18, 2021

I think we need better typing around config in general

export interface SimulationOptions {
  options?: Record<string, unknown>;
  services?: Record<string, {
    port?: number;
  }>
}

options?: Record<string, unknown> does not offer much to keep someone on the straight and narrow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants