Skip to content

Conversation

@bastelfreak
Copy link
Member

No description provided.

@evgeni
Copy link
Member

evgeni commented Nov 20, 2025

CI sagt nein

@bastelfreak
Copy link
Member Author

CI sagt jetzt ja! (I will add more tests, please don't merge yet)

@bastelfreak bastelfreak force-pushed the smart branch 2 times, most recently from dc8d365 to 5690b65 Compare November 20, 2025 17:26
@evgeni evgeni marked this pull request as draft November 20, 2025 17:39
@evgeni
Copy link
Member

evgeni commented Nov 20, 2025

Undraft when ready? :)

@bastelfreak
Copy link
Member Author

this is pending the deb packages 😿

@evgeni
Copy link
Member

evgeni commented Nov 21, 2025

Didn't we do them last week?

@bastelfreak
Copy link
Member Author

The rpms are on the mirror, but I couldn't fine the deb packages :(

@evgeni
Copy link
Member

evgeni commented Nov 21, 2025

@bastelfreak bastelfreak marked this pull request as ready for review November 27, 2025 10:05
@bastelfreak
Copy link
Member Author

bastelfreak commented Nov 27, 2025

works now, I also tested it locally. And for foreman itself: theforeman/puppet-foreman#1249

Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For advanced vs regular parameters: in the installer it determines whether --help shows it or only in --full-help.

@ekohl ekohl merged commit 9498e23 into theforeman:master Nov 28, 2025
9 checks passed
@bastelfreak bastelfreak deleted the smart branch November 28, 2025 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants