Skip to content

Add support for exempting i18n/translation commits from Redmine validation #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ogajduse wants to merge 1 commit into
base: app
Choose a base branch
from
Open

Add support for exempting i18n/translation commits from Redmine validation #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions prprocessor/__main__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
re.IGNORECASE,
)
COMMIT_ISSUES_REGEX = re.compile(r'#(\d+)')
EXEMPT_COMMIT_REGEX = re.compile(r'^i18n - (extracting new, )?pulling from tx$', re.IGNORECASE)
CHECK_NAME = 'Redmine issues'
WHITELISTED_ORGANIZATIONS = ('theforeman', 'Katello')

Expand Down Expand Up @@ -66,7 +67,12 @@ class Commit:

@property
def subject(self):
return self.message.splitlines()[0]
lines = self.message.splitlines()
return lines[0] if lines else ""

def is_exempt(self) -> bool:
"""Check if commit is exempt from Redmine validation (i18n commits)."""
return EXEMPT_COMMIT_REGEX.match(self.subject) is not None


@dataclass
Expand Down Expand Up @@ -213,7 +219,7 @@ async def get_issues_from_pr(pull_request: Mapping) -> tuple[IssueValidation, Co
async for commit in get_commits_from_pull_request(pull_request):
issue_ids.update(commit.fixes)
issue_ids.update(commit.refs)
if config.required and not commit.fixes and not commit.refs:
if config.required and not commit.fixes and not commit.refs and not commit.is_exempt():
invalid_commits.append(commit)

return verify_issues(config, issue_ids), invalid_commits
Expand Down