-
Notifications
You must be signed in to change notification settings - Fork 107
Why assign rolling CVs to LCEs #4503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates rolling content view documentation to explain their use beyond the Library lifecycle environment and clarifies the procedure for assigning rolling content views to lifecycle environments. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `guides/common/modules/con_rolling-content-views.adoc:14` </location>
<code_context>
Instead, you can assign rolling content views to one or multiple lifecycle environments.
-This allows you to control which content is synchronized from {ProjectServer} to {SmartProxyServers}.
+By doing so, you can synchronize subsets of the Library content from {ProjectServer} to {SmartProxyServers} that are configured to consume content from the assigned lifecycle environments.
</code_context>
<issue_to_address>
**issue (review_instructions):** The phrase "that are configured to consume" uses passive voice, which the guidelines ask us to avoid.
To avoid passive voice, consider rephrasing this part of the sentence. For example:
"By doing so, you can synchronize subsets of the Library content from {ProjectServer} to {SmartProxyServers} that you configure to consume content from the assigned lifecycle environments."
This keeps the meaning while using active voice.
<details>
<summary>Review instructions:</summary>
**Path patterns:** `guides/common/*.adoc,guides/common/modules/*.adoc`
**Instructions:**
Avoid passive voice in verbs.
</details>
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
|
The PR preview for dc33306 is available at theforeman-foreman-documentation-preview-pr-4503.surge.sh The following output files are affected by this PR: |
|
@quba42 and @ianballou Can you please take a look and confirm that the explanations are correct? Also, should we cherry pick this to 3.17? |
maximiliankolb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested Hammer CLI on Foreman 3.16: ✔️
$ hammer content-view list --organization-id 1 --fields "content view id,name"
----------------|----------------------------------------------------------
CONTENT VIEW ID | NAME
----------------|----------------------------------------------------------
2 | AlmaLinux 10_CV
56 | AlmaLinux 10_RCV
3 | AlmaLinux 9_CV
...
| You can assign your rolling content view to lifecycle environments to limit content synchronized to {SmartProxyServers}. | ||
|
|
||
| You can assign rolling content views to Library. | ||
| However, Library usually contains many repositories and synchronizing the whole Library to {SmartProxyServers} can be time consuming. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| However, Library usually contains many repositories and synchronizing the whole Library to {SmartProxyServers} can be time consuming. | |
| However, Library contains all products and repositories. | |
| Therefore, synchronizing Library to {SmartProxyServers} is time consuming. |
| You can assign rolling content views to Library. | ||
| However, Library usually contains many repositories and synchronizing the whole Library to {SmartProxyServers} can be time consuming. | ||
| Therefore, {Team} recommends assigning rolling content views to other lifecycle environments. | ||
| By using other lifecycle environments, you can subscribe hosts to other lifecycle environments than Library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can, so it's technically true. But the benefit of using rolling CV in LE other than Library is that you can only sync a subset of your content to Smart Proxy Servers and therefore save bandwith and disk space on Smart Proxy Servers. I suggest to reword this or drop it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @maximiliankolb here.
Also, we don't need to mention it since assigning an LCE is essentially free, but users who don't use smart proxies don't really need to care about what LCE they assign to their rolling CVs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the particular line here, subscribing hosts to LCEs other than library isn't really a benefit by itself, especially with rolling CVs.
|
@Lennonka I am struggling to come up with a text that is both accurate, and complete without becoming very longwinded. The following accurately and completely describes the background, but needs to be shortened back down. I post it in the hope that it helps you to further refine a final text: Whatever you decide to pull or not to pull from my text, I do recommend making the recommendation not to assign rolling content views to Library very explicit in the docs. |
What changes are you introducing?
Explaining why one should assign rolling content views to other LCEs than Library
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
SAT-37738 (public)
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
Contributor checklists
Please cherry-pick my commits into: ???
Summary by Sourcery
Documentation: