-
-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Symbols are not found for safe 3.0 #617
Comments
As a guess, is I wonder if there's a way to tell (If it's using some other mechanism then the solution would be completely different, I'm just making guesses about how |
Also perhaps there's something we could add to |
I don't know if there is something that can be defined on the composer-level... |
I wonder if you could actually make tagged releases or branches that discard this version checking and only include the correct code for that version directly in the generated file. Then anyone with this issue (which would include me when I start using it) can just ensure they have the correct safe tag Another option is that this library becomes simply a way to generate files directly in your own project. That might also allow for a much leaner codebase with only the required safe functions included - I wonder if this could be handled with rector somehow? Just a bit of wondering in general really |
We had this discussion in #500 - tl;dr the current approach is ugly, but every other approach is worse D: |
The documentation suggests that you can use wildcards, so
|
Sadly this doesn't work, tried this as I found my solution. When using the wildcard every unused function is printed as unknown. But I really don't know why... Here's an excerpt:
|
When using
composer-require-checker
with in a project with safe 3.0 I get these unknown symbols:When I switch back to 2.5 no unknown symbols are found. I tried to find the differences, but nothing obvious.
Anyone know how to handle this?
The text was updated successfully, but these errors were encountered: