::devMode and ::prodMode with optional parameter?

[josefsabl]

Maybe the GraphQLite\SchemaFactory::devMode and GraphQLite\SchemaFactory::prodMode could accept an optional parameter like this:

function devMode(bool $v = true);
function prodMode(bool $v = true);

This way, instead of:

$schemaFactory
  ->addNamespace
  ->setFinder(...);

if (DEV_MODE) {
  $schemaFactory->devMode();
} else {
  $schemaFactory->prodMode();
}

One could simply write:

$schemaFactory
  ->addNamespace
  ->setFinder(...);
  ->devMode(DEV_MODE);

[enricobono]

Hello @josefsabl.
What's the need behind your proposal?

[oojacoboo]

@josefsabl I agree that the API is unfortunate... This wouldn't be a BC break and I'm open to a PR. Thanks.

[oprypkhantc]

Yeah I noticed that one too. devMode could just default to false, and accept a default parameter of true:

class SchemaFactory {
    private bool $devMode = false;

    public function devMode(bool $value = true): self
    {
        $this->devMode = $value;

        return $this;
    }
}