Added an optional config the R3F sheet context #502
+26
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an optional config to the sheet context in the R3F package with the option for a namespace prefix. When using the library I like the ability to group objects by namespace but it's tedious to do that for ever object in a scene. The SheetProvider seemed the most sensible place to add this option and I opted to make it a whole config so it could be expanded in the future to include other options.
In the future, it might make sense to rename
SheetProvider
toR3FSheetProvider
, or something similar, to avoid confusion from users who might want to use the provider outside of fiber.Note: I was not able to properly setup the repo because I encountered this error when trying to run yarn:
Workspaces can only be enabled in private projects.
. I don't normally use yarn and I'm not sure what the issue is.