Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new features #3

Open
the-ethan-hunt opened this issue Nov 14, 2017 · 5 comments
Open

Add new features #3

the-ethan-hunt opened this issue Nov 14, 2017 · 5 comments

Comments

@the-ethan-hunt
Copy link
Owner

B.E.N.J.I. can have more features! Add them and push a PR!

@sara-02
Copy link

sara-02 commented Jul 23, 2018

Kindly give a brief description of your new feature here(before jumping to the implementation), and tag the mentors @the-ethan-hunt, @abhimanyuthakre, @sara-02 for suggestions. It will help in better approval of the idea and better design as well.

@abhimanyuthakre
Copy link
Collaborator

I have an idea of showing user the lyrics by using "lyrics song_name". If there are songs with similar names, user can use more specific string which includes singer too, as the result would be about the famous song only. This feature will directly lead to the website. @the-ethan-hunt @sara-02

@the-ethan-hunt
Copy link
Owner Author

This seems good @abhimanyuthakre . We can also use a music recognizer (like Shazam!) incorporated with this functionality.
P.S. @sara-02 , @abhimanyuthakre is the other maintainer of the project. 😄

@sara-02
Copy link

sara-02 commented Jul 24, 2018

Thanks, updated my previous comment to include @abhimanyuthakre as well 😉

@Pratik-Sanghani
Copy link
Contributor

Sorry , @sara-02 @the-ethan-hunt @abhimanyuthakre .
I was not aware from this and direct implemented the feature.
Please review this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants