Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace go-kit/log with log/slog #7949

Open
yeya24 opened this issue Dec 1, 2024 · 1 comment · May be fixed by #7969
Open

Replace go-kit/log with log/slog #7949

yeya24 opened this issue Dec 1, 2024 · 1 comment · May be fixed by #7969

Comments

@yeya24
Copy link
Contributor

yeya24 commented Dec 1, 2024

Similar to prometheus/prometheus#14355

Prometheus has switched to use log/slog and remove go-kit/log. In order to be compatible with Prometheus to pull latest Prometheus code, Thanos needs to switch to use slog.

This can be used as a meta issue to split the work and track the progress.

Related:
@yeya24 yeya24 mentioned this issue Dec 1, 2024
Open
@yeya24
Copy link
Contributor Author

yeya24 commented Dec 2, 2024

It might be too much work to replace the whole go-kit/log to use slog. It might be good to go with the approach of adapter using https://github.com/tjhop/slog-gokit

@SungJin1212 SungJin1212 linked a pull request Dec 9, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add a func converting go-kit log to slog SungJin1212/thanos
1 participant
@yeya24