Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider capturing reconciliation metrics #170

Closed
philipgough opened this issue Nov 21, 2024 · 0 comments · Fixed by #183
Closed

Reconsider capturing reconciliation metrics #170

philipgough opened this issue Nov 21, 2024 · 0 comments · Fixed by #183

Comments

@philipgough
Copy link
Collaborator

In #81 we moved out some reconciliation metrics to a metrics package. However these metrics, and more appear to be already captured via controller-runtime (screenshot attached).

The suggestion here is to consider removing the custom metrics that duplicate the existing data and focus only on capturing specific useful metrics per component where necessary.

image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant