Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ordering too much stuff crashes the client upon opening the "Requests" panel #16237

Open
Ldip999 opened this issue Jul 2, 2024 · 0 comments · May be fixed by #16245
Open

Ordering too much stuff crashes the client upon opening the "Requests" panel #16237

Ldip999 opened this issue Jul 2, 2024 · 0 comments · May be fixed by #16245
Labels
Bug Incorrect functionality.

Comments

@Ldip999
Copy link
Contributor

Ldip999 commented Jul 2, 2024

Description

If someone orders enough stuff, the client will hang and be stuck trying to render hunders to thousands of orders. Why is this problematic? I've had it happen to me that Grug marineface refused to deploy until I got him his rocket sledge 5 minutes into the OP and when I said no he bricked req until an admin cleared the list for me. This should be fixed because grieffing is bad.

Test Merges

BYOND Version: 515.1635
Server revision compiled on: 2024-07-02
Master commit: cb373bf0f88258b5d85b08f81f7e5aa7985d8ca7

(aka local server without any testmerges)

Reproduction Steps

  1. Go to req
  2. Order 1000+ of anything
  3. Have your client hang and lag for several seconds
  4. Order 5000+ of anything
  5. Have your client hang and brick permamently until you restart the game or somehow manage to close the window

Screenshots

No response

@Ldip999 Ldip999 added the Bug Incorrect functionality. label Jul 2, 2024
@Ldip999 Ldip999 linked a pull request Jul 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant