Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighted Text On Seperate Line in Announcement Messages #16174

Closed
Runian opened this issue Jun 26, 2024 · 3 comments
Closed

Highlighted Text On Seperate Line in Announcement Messages #16174

Runian opened this issue Jun 26, 2024 · 3 comments
Labels
Bug Incorrect functionality.

Comments

@Runian
Copy link
Contributor

Runian commented Jun 26, 2024

Description

Expected: An announcement message where only the specific word/text is highlighted.
What happened: An announcement message where the specific word/text is given its own line as if there was a line break before and after it.

Test Merges

#15935: 'New Map: LV-759' by RipGrayson at commit 539ac2bde4
#16001: 'Boiler Tweaks' by Barnet2 at commit 06af187fb4
#16114: 'Desant fix' by Lumipharon at commit b8a986e73d
#16118: 'Revert "Light interior fix"' by TiviPlus at commit c93913a1a2
#15961: 'Opt-in squad radio TTS' by breadhunt at commit f30d58307b
#16087: 'More chat style updates - new announcement colors, admin announcement changes, and more' by Neocloudy at commit b36594a998
#16097: 'Tank balance' by Lumipharon at commit 150ef270ee

Reproduction Steps

  1. Use Text Highlights
  2. Have these as the hightlighted words: "ai, mini, vert, subvert, mini, ark, shaffer, william, hive, hivemind, mortar, shells, Remote targeting set by"
  3. Get announcement that features one of the words.
  4. Look at announcement; it is not looking good.

Screenshots

image

image

@Runian Runian added the Bug Incorrect functionality. label Jun 26, 2024
@Neocloudy
Copy link
Contributor

this shall be probably fixed on next server update, please close :D
image

@CoastalCookie
Copy link

this shall be probably fixed on next server update, please close :D

image

You should have made the pr manually close it... people open issues and then forget about them

cause 90% of these issues are not maintained or even checked if they are valid to this day

@Runian
Copy link
Contributor Author

Runian commented Jun 29, 2024

oh. i have a button, whoops

@Runian Runian closed this as completed Jun 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

3 participants