Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pounce through water offset #15865

Closed
ju45he opened this issue May 14, 2024 · 1 comment · Fixed by #15894
Closed

Pounce through water offset #15865

ju45he opened this issue May 14, 2024 · 1 comment · Fixed by #15894
Labels
Bug Incorrect functionality.

Comments

@ju45he
Copy link

ju45he commented May 14, 2024

Description

I was playing hunter one day on TGMC and I pounced and my sprite got offset upwards permenantly, did it a few more times and it stacked.

Test Merges

Server-Side Code Modifications: https://tgstation13.org/parsed-logs/sybil/server_side_modifications.dm

Round ID: 26988
BYOND Version: 515.1633
Server revision compiled on: 2024-05-14T18:52:38+00:00
Master commit: 6b197a65a4bade96ede91042db1adc2e7aeae68e
The following pull requests are currently test merged:
#15682: 'Smooth move update' by Lumipharon at commit 7782067652
#15647: 'Health analyzer update' by Neocloudy at commit b4d0ee7abe
#15783: 'Adds the CPC (Clone Personnel Carrier) module' by Lumipharon at commit bcabb5fabf
#15839: 'Ports Kutjevo Refinery' by RipGrayson at commit c6cf651025

Local commit: 3f6792e
Server tools version: 6.5.0

Reproduction Steps

  1. Go to some water
  2. Play as some caste that has access to some sort of pounce like hunter
  3. Pounce across the water, from land on one side to land on the other
  4. Sprite is offset and can be stacked to unreasonable degree

Screenshots

image

@ju45he ju45he added the Bug Incorrect functionality. label May 14, 2024
@Lumipharon
Copy link
Contributor

this is due to throws (which includes pounces) basically traveling faster than its expecting a mob to move.
When it goes onto a shore turf, it removes the filter, on a timer based on your move delay. When you leave the shore turf for dry land, it checks again to make sure it removes the filter, but during a throw, you move faster than your move delay would allow, so you do in fact still have that filter again. So it removes it again, including adjusting the pixel_y.

Ultimately this behavior probably needs to be on an SS instead of the turf itself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants