Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Armor and clothing vendors dissapear (flicker) when restocking items #15711

Closed
antropod opened this issue Apr 24, 2024 · 1 comment
Closed

Armor and clothing vendors dissapear (flicker) when restocking items #15711

antropod opened this issue Apr 24, 2024 · 1 comment
Labels
Bug Incorrect functionality.

Comments

@antropod
Copy link
Contributor

antropod commented Apr 24, 2024

Description

When you restock items into clother or armor vendor they flicker and disappear for a second

Test Merges

Round ID: 26707
BYOND Version: 515.1626
Server revision compiled on: 2024-04-23T23:12:11+00:00
Master commit: b62f060788bafe489e8304334640bd9c80f012d5
The following pull requests are currently test merged:
#15682: 'Smooth move update' by Lumipharon at commit a1f2eeb30e

Local commit: 0a08d33
Server tools version: 6.4.0

Reproduction Steps

Buy anything from armor or clothes vendor
Restock it

Screenshots

No response

@antropod antropod added the Bug Incorrect functionality. label Apr 24, 2024
@antropod antropod changed the title Armor and clothing vendors dissapear when restocking items Armor and clothing vendors dissapear (flicker) when restocking items Apr 24, 2024
@antropod
Copy link
Contributor Author

I don't undestand why, but by dissecting the issue I found that icon is broken after #15508
reproduction - checkout one commit before the PR
git checkout a036d859de^
build
go to clothes vendor, buy and restock any item - vendor does not flicker

and after
git checkout a036d859de
build
-- vendor does flicker

I don't know the icon system well enough to figure out why this is happening. I think that PR added an error icon for clothes vendor?

Another fact, the icon state surplus-vend does not exist in vending.dmi, it is misspelled as surplus-vent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

2 participants