Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Dispenser All" on cryo storage only dispenses guns #15443

Closed
Xander3359 opened this issue Mar 22, 2024 · 6 comments
Closed

"Dispenser All" on cryo storage only dispenses guns #15443

Xander3359 opened this issue Mar 22, 2024 · 6 comments
Labels
Bug Incorrect functionality.

Comments

@Xander3359
Copy link
Contributor

Description

  • Click dispense all thinking everything will dispense
  • Only guns come out

Test Merges

.

Reproduction Steps

  • Make roomba pick up various items
  • Go to cryo and click "Dispense All"
  • Only guns appear

Screenshots

No response

@Xander3359 Xander3359 added the Bug Incorrect functionality. label Mar 22, 2024
@Lumipharon
Copy link
Contributor

test your prs dfjsdhfskjdnf

@lbnesquik
Copy link
Contributor

Aoeugh, I'll get on this. It worked before I tried to get smart about my code.

@lbnesquik
Copy link
Contributor

lbnesquik commented Mar 23, 2024

Right, I'll PR my fix soon, but the MRE's get lost because the roomba PR now tries to unload things first. So the game puts the MRE's into the containers area, and the MRE components into the other category. This leads to empty MRE's, but that's because the unloading is too zealous.

Like, as far as I can see, it is emptying pill bottles and putting 16 pills into the cryo storage.

@ghost
Copy link

ghost commented Mar 25, 2024

fwiw it's always emptied pill bottles and stored them separate as container and the 16 pills inside of them

@lbnesquik
Copy link
Contributor

fwiw it's always emptied pill bottles and stored them separate as container and the 16 pills inside of them

That issue predates both of our PR's. I reverted to 1 month ago, and it still did that. Should probably get a fix sometimes.

@lbnesquik
Copy link
Contributor

Can be marked as fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

3 participants