Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Artillery Impact Tablet seems to not properly follow shots #13629

Open
lbnesquik opened this issue Jul 29, 2023 · 0 comments
Open

The Artillery Impact Tablet seems to not properly follow shots #13629

lbnesquik opened this issue Jul 29, 2023 · 0 comments
Labels
Bug Incorrect functionality.

Comments

@lbnesquik
Copy link
Contributor

lbnesquik commented Jul 29, 2023

Description

When you use the tablet, you expect to see 1-2 seconds of the area before the round land, and 1-2 seconds after it does. The code writes it is 5 seconds, but that's roughly what you want.

However, what seems to happen is that during long range shots, the tablet immediately moves the camera used by the tablet, and you only see a single frame of the shot landing, if even that. That seems to not be intended behavior.

I gave a try at fixing it, but I didn't manage to do much headway.

Test Merges

Server-Side Code Modifications: https://tgstation13.org/parsed-logs/sybil/server_side_modifications.dm

Round ID: 22451
BYOND Version: 515.1610
Server revision compiled on:
Master commit: 692448ad6aefba23611c274b6b68293ccaaa740e
The following pull requests are currently test merged:
#13426: 'Adds a HUD text timer for both hive collapse and nuke' by Arturlang at commit eaacb35297
#13515: 'Adds 2 new tadpole models' by XANAv2 at commit 314c2a0a18
#13566: 'Lawanka Outpost' by Barnet2 at commit 7aafde85d0
#13546: 'Port tg statpanel' by forestbbbbbbb at commit 12643528fa
#13594: 'Normalises stagger/slowdown recovery back to previous values' by ivanmixo at commit f87f775631
#13123: 'Shrike primo rework - Psychic Vortex' by Scarlet-Oduko at commit 9c0ec8d6a0
#13483: 'Adds SG-62 Target Rifle, a new SG gun with an underbarreled spotting rifle. MK2' by Pariah919 at commit 0426e338ef
#13627: 'Fix orbit menu' by TiviPlus at commit 49ed42662a

Local commit: 5a6d0dd
Server tools version: 5.13.4

Reproduction Steps

Use artillery
Fire a shot at long or extreme range
Use your tablet to see the impact
Never see anything

Screenshots

No response

@lbnesquik lbnesquik added the Bug Incorrect functionality. label Jul 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Incorrect functionality.
Projects
None yet
Development

No branches or pull requests

1 participant