Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Based on old upstream miniz version with security vulnerabilities #15

Open
cleeus opened this issue Oct 21, 2020 · 3 comments
Open

Based on old upstream miniz version with security vulnerabilities #15

cleeus opened this issue Oct 21, 2020 · 3 comments

Comments

@cleeus
Copy link

cleeus commented Oct 21, 2020

miniz-cpp is based on an old version of zlib/minizip and contains security vulnerabilities. See this example/failing test here: cleeus@d233931

I understand that this project is not in active development but it would be good to point this out in the README, otherwise this code might end up in critical code paths (and it probably alread has). There is a modern, well maintained version of minizip in https://github.com/nmoinvaz/minizip.

@cleeus
Copy link
Author

cleeus commented Oct 22, 2020

This is a file that crashes with a heap corruption when any of the contained files are decompressed:
id_000003.zip

@harry75369
Copy link

miniz-cpp is actually not based on any of zlib/minizip, but on miniz. miniz is an independent implementation of zlib compression algorithm.

but code updates from upstream miniz is needed anyway...

@cleeus cleeus changed the title Based on old zlib/minizip version with security vulnerabilities Based on old upstream miniz version with security vulnerabilities Dec 16, 2020
@cleeus
Copy link
Author

cleeus commented Dec 16, 2020

Thanks for the correction, I confused the two since the code looks so similar. I changed the issue title accordingly.

Is this the authoritative upstream?
https://github.com/richgel999/miniz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants