Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong YAML syntax highlighting in some corner cases for strings #29

Open
Tracked by #1
aeschli opened this issue Sep 14, 2018 · 4 comments
Open
Tracked by #1

Wrong YAML syntax highlighting in some corner cases for strings #29

aeschli opened this issue Sep 14, 2018 · 4 comments

Comments

@aeschli
Copy link

aeschli commented Sep 14, 2018

From @yajo on July 30, 2018 9:21

Issue Type: Bug

Comments inside the image explain the wrong syntax highlighting problems; see:
captura de pantalla de 2018-07-30 10-20-20

Copied from original issue: microsoft/vscode#55355

@aeschli
Copy link
Author

aeschli commented Sep 14, 2018

@yajo Would you mind pasting the code example here? Thanks a lot!

@aeschli
Copy link
Author

aeschli commented Sep 14, 2018

From @texastoland on July 31, 2018 4:57

Same here:

key: string
  "flows" | here
#         ^^^^^^ highlighted

Surely related to #17.

@aeschli
Copy link
Author

aeschli commented Sep 14, 2018

From @yajo on July 31, 2018 9:50

# Highlight here is OK
- name: build docker-compose project {{ project.key }}
  # Highlight is misleading. All of this block is a string
  split spaces: |
    - i'm a string
    - [not an array]
    - {nor a dict}
  # same here
  join spaces: >
    - i'm a string
    - [not an array]
    - {nor a dict}
  when:
    # This is all a single string
    - not build_cache|bool or "ERROR: for odoo" in result.stderr
  command:
    # Highlighting in line 42 is misleading. All of this is a string too
    docker-compose build --pull
    {% if not build_cache|bool %} --no-cache {% endif %}

@uishon
Copy link

uishon commented Jun 6, 2019

Any chance this will be handled in the near future? Please don't give up on it... It's annoying...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants