Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax highlighting for YAML documents breaks with certain single quotes #20

Closed
aeschli opened this issue Sep 22, 2017 · 2 comments
Closed

Comments

@aeschli
Copy link

aeschli commented Sep 22, 2017

From @nchammas on September 21, 2017 15:40

  • VSCode Version: 1.16.1
  • OS Version: macOS 10.12.6

Steps to Reproduce:

Check out the syntax highlighting on this file:

- hosts: localhost
    - name: Create EMR cluster
      command: >
        aws emr create-cluster \
            --name "{{cluster_name}}" \
            --release-label "emr-{{emr_version}}" \
            --applications "Name=Hadoop" "Name=Spark" "Name=Zeppelin" \
            --no-auto-terminate \
            --auto-scaling-role "EMR_AutoScaling_DefaultRole" \
            --use-default-roles \
            --log-uri {{log_uri}} \
            --ec2-attributes '{
                "KeyName": "{{key_name}}",
                "SubnetId": "{{subnet_id}}",
                "AdditionalMasterSecurityGroups": {{additional_security_groups | to_json}},
                "AdditionalSlaveSecurityGroups": {{additional_security_groups | to_json}}
            }' \
            --instance-groups file://files/instance-group-config.json \
            --scale-down-behavior TERMINATE_AT_TASK_COMPLETION \
            --bootstrap-action "Path={{bootstrap_uri}}" \
            --tags {{emr_tags}}
      register: create_cluster
    #
    # Coloring works fine here on GitHub.
    #
    - set_fact:
        cluster_id: "{{(create_cluster.stdout | from_json).ClusterId}}"

Looks fine here, but on VS Code it's broken:

screen shot 2017-09-21 at 11 32 49 am

It appears that the single quotes from L12-L17 break syntax highlighting for everything afterwards.

Reproduces without extensions: Yes

Copied from original issue: microsoft/vscode#34761

@infininight
Copy link
Member

infininight commented May 4, 2018

Unable to reproduce this in TextMate with the current grammar, I get line 23-25 as a comment with the string ending correctly. So this may be an engine difference between TextMate and VSCode.

cc @nchammas

Edit: Scratch this, there is an issue but it's an edge case depending on the order the content is entered. Doing further testing now.

@infininight
Copy link
Member

OK, this is actually a duplicate of #17. Slightly different trigger but the same cause, working to figure out a solution now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants